Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framer.ai #1831

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

koenrh
Copy link
Contributor

@koenrh koenrh commented Aug 22, 2023

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Organization Website: https://www.framer.com

My name is Koen Rouwhorst, I'm the Head of Security at Framer, and I'm representing them in this inclusion request.

Framer is an interactive design tool for building websites and prototypes. These websites and prototypes can be published on the web.

Reason for PSL Inclusion

Past requests: #1217 and #1570

Framer is an interactive design tool for building websites and prototypes. Customers can publish their websites under a (custom) domain name. Customers can bring their own domain name, but also use a sub-domain of one of the Framer-provided domains such as framer.app and framer.website. The reason for inclusion is to provide better isolation between the customer sites published on these sub-domains.

We would like to add framer.ai to the PSL. Sites built by customers using Framer AI will be published as a sub-domain under the framer.ai domain.

The registry expiry date for the framer.ai domain name is January 5, 2028.

Number of users this request is being made to serve: Based on current usage numbers, approximately hundreds of thousands.

DNS Verification via dig

dig +short TXT _psl.framer.ai
"https://github.com/publicsuffix/list/pull/1831"

Results of Syntax Checker (make test)

I successfully ran the test.

Results of Syntax Checker
cd linter;                                \
	  ./pslint_selftest.sh;                     \
	  ./pslint.py ../public_suffix_list.dat;
-n test_NFKC:
OK
-n test_allowedchars:
OK
-n test_dots:
OK
-n test_duplicate:
OK
-n test_exception:
OK
-n test_punycode:
OK
-n test_section1:
OK
-n test_section2:
OK
-n test_section3:
OK
-n test_section4:
OK
-n test_spaces:
OK
-n test_wildcard:
OK
test -d libpsl || git clone --depth=1 https://github.com/rockdaboot/libpsl;   \
	  cd libpsl;                                                                    \
	  git pull;                                                                     \
	  echo "EXTRA_DIST =" >  gtk-doc.make;                                          \
	  echo "CLEANFILES =" >> gtk-doc.make;                                          \
	  autoreconf --install --force --symlink;
Already up to date.
autopoint: using AM_GNU_GETTEXT_REQUIRE_VERSION instead of AM_GNU_GETTEXT_VERSION
glibtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
glibtoolize: linking file 'build-aux/ltmain.sh'
glibtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
glibtoolize: linking file 'm4/libtool.m4'
glibtoolize: linking file 'm4/ltoptions.m4'
glibtoolize: linking file 'm4/ltsugar.m4'
glibtoolize: linking file 'm4/ltversion.m4'
glibtoolize: linking file 'm4/lt~obsolete.m4'
configure.ac:1: warning: file `version.txt' included several times
configure.ac:4: warning: file `version.txt' included several times
aclocal.m4:765: AM_INIT_AUTOMAKE is expanded from...
configure.ac:4: the top level
configure.ac:383: warning: file `version.txt' included several times
configure.ac:10: installing 'build-aux/compile'
configure.ac:4: installing 'build-aux/missing'
fuzz/Makefile.am: installing 'build-aux/depcomp'
cd libpsl && ./configure -q -C --enable-runtime=libicu --enable-builtin=libicu --with-psl-file=/Users/koen/src/github.com/publicsuffix/list/public_suffix_list.dat --with-psl-testfile=/Users/koen/src/github.com/publicsuffix/list/tests/tests.txt && make -s clean && make -s check -j4
configure: WARNING: --enable-builtin=libicu is deprecated, use --enable-builtin (enabled by default)
config.status: creating po/POTFILES
config.status: creating po/Makefile
Making clean in po
Making clean in include
Making clean in src
rm -f ./so_locations
Making clean in tools
 rm -f psl
Making clean in fuzz
 rm -f libpsl_icu_fuzzer libpsl_icu_load_fuzzer libpsl_icu_load_dafsa_fuzzer
Making clean in tests
 rm -f test-is-public test-is-public-all test-is-cookie-domain-acceptable test-is-public-builtin test-registrable-domain
Making clean in msvc
Making check in po
Making check in include
Making check in src
  CC       libpsl_la-lookup_string_in_fixed_set.lo
  CC       libpsl_la-psl.lo
  CCLD     libpsl.la
Making check in tools
  CC       psl.o
  CCLD     psl
Making check in fuzz
  CC       main.o
  CC       libpsl_fuzzer.o
  CC       libpsl_load_fuzzer.o
  CC       libpsl_load_dafsa_fuzzer.o
  CCLD     libpsl_icu_fuzzer
  CCLD     libpsl_icu_load_fuzzer
  CCLD     libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_load_dafsa_fuzzer
PASS: libpsl_icu_fuzzer
PASS: libpsl_icu_load_fuzzer
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-public
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public-all
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: assuming '-no-fast-install' instead
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
  CCLD     test-registrable-domain
libtool: warning: '-no-install' is ignored for aarch64-apple-darwin22.6.0
libtool: warning: assuming '-no-fast-install' instead
PASS: test-is-public-all
PASS: test-is-public
PASS: test-is-cookie-domain-acceptable
PASS: test-is-public-builtin
PASS: test-registrable-domain
============================================================================
Testsuite summary for libpsl 0.21.2
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

@koenrh koenrh marked this pull request as ready for review August 22, 2023 16:20
@dnsguru dnsguru changed the title Add framer.ai Add framer.ai Sep 1, 2023
@koenrh
Copy link
Contributor Author

koenrh commented Feb 28, 2024

Hi @dnsguru - Any chance we could move this pull request forward and get it merged? Thank you!

@simon-friedberger
Copy link
Contributor

simon-friedberger commented Mar 4, 2024

  • Expiration (Note: Must STAY >2y at all times)
    • framer.ai expires 2028-01-05 (see comment)
    • framer.app expires 2026-10-02
    • framercanvas.com expires 2027-02-18
    • framer.media expires 2026-11-19
    • framer.photos expires 2026-11-19
    • framer.website expires 2026-11-19
    • framer.wiki expires 2026-11-19
  • DNS _psl entries (Note: Must STAY in place)
  • Tests pass
  • Sorting
  • Reasoning/Organization description

@simon-friedberger simon-friedberger added ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Mar 4, 2024
@koenrh koenrh force-pushed the add-framer-ai-to-psl branch from b932254 to e9b6a41 Compare March 11, 2024 13:34
@koenrh
Copy link
Contributor Author

koenrh commented Mar 11, 2024

Thanks, @simon-friedberger.

The newly added domain framer.ai is valid until January 5, 2028.

domains cscglobal com_cds-app_dmPortfolio htm

I also added another 24 months to the previously added domain names.

@koenrh
Copy link
Contributor Author

koenrh commented Apr 5, 2024

Hi @simon-friedberger, could you have another look? Thanks.

@simon-friedberger simon-friedberger added r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger and removed ❌FAIL - DOMAIN NOT 2Y+ *ALL* names in PRIVATE section MUST hold terms of 2 years or more registration from PR date #1109 labels Apr 10, 2024
@simon-friedberger simon-friedberger merged commit 1534d35 into publicsuffix:master Apr 10, 2024
1 check passed
@koenrh koenrh deleted the add-framer-ai-to-psl branch April 11, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

2 participants